aio-libs / aio-libs/aiosmtpd

flake8-logging-format partially configured but not listed in dependencies

Ouverte
#606 0 commentaires 0 réactions 1 personne assignée Réclamée par @loqs Voir sur GitHub
Langage dominant
Python
Étoiles
373
Forks
105
Merge moyen
4 min
PR mergées (30 j)
2

Description

8d81f96f3d91de995ecbcae01805f21a71410790 by @Dreamsorcerer added `enable-extensions = G` to the flake8 section of setup.cfg. Which would enable rules with the G prefix that are not enabled by default such as those provided by flake8-logging-format. flake8-logging-format was not added to requirements-dev.txt or tox.ini so no rules match the G prefix. Additionally G is not listed in the select entry. With G rules selected and flake8-logging-format installed:
```
$ flake8 --select "G" aiosmtpd
pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
aiosmtpd/main.py:279:15: G004 Logging statement uses f-string
aiosmtpd/proxy_protocol.py:310:25: G004 Logging statement uses f-string
aiosmtpd/smtp.py:408:13: G003 Logging statement uses '+'
aiosmtpd/smtp.py:410:17: G003 Logging statement uses '+'
aiosmtpd/smtp.py:817:22: G004 Logging statement uses f-strin
```
G004 violations are also covered by PIE803 which are ignored in setup.cfg with the comment `Use f'strings instead of % formatters, the performance impact isn't too bad and f'strings are awesome!`.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.