aio-libs / aio-libs/aiosmtpd

Stop inheriting from `StreamReaderProtocol`?

Ouverte
#210 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
compatibility in progress tech-debt
Langage dominant
Python
Étoiles
373
Forks
105
Merge moyen
4 min
PR mergées (30 j)
2

Description

I was in the process of eyeballing the docs and fixing things when I came upon a `:ref:` that steadfastly refused to resolve:

:class:`asyncio.StreamReaderProtocol`

After hunting around, apparently that class was last documented in **Python 3.6**: https://docs.python.org/3.6/library/asyncio-stream.html#streamreaderprotocol

It's gone since **Python 3.7**, that's why the `:ref:` won't resolve.

Digging deeper, I found [`bpo-37639`](https://bugs.python.org/issue37639) with comment from @asvetlov (I'm assuming the same person, apologies if not):

> We are striving to remove it from public API step by step: documentation-deprecation-removal.
>
> If you really need the class -- please copy-paste the source lines into your project and use the copy on your own.

So, will we stop inheriting from that class and as suggested, just copy-and-paste the source lines?

I fear that one day things will blow up if this class's definition got removed and/or remade... which is why I'm adding the `[tech-debt]` label there.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.