Automatically handle parallel queries with an async `Lock`
- Lenguaje dominante
- Python
- Estrellas
- 1.9k
- Forks
- 272
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
### Is your feature request related to a problem?
When performing two "parallel" queries via `asyncio.gather`, an error is thrown:
```RuntimeError: readexactly() called while another coroutine is already waiting for incoming data```
### Describe the solution you'd like
I have implemented a simple yet effective way to remedy this issue however it's quite "gross", requiring monkey patching as I am unable to perform the required changes in a type safe manner:
```python
class LockedCursor(Cursor):
def get_lock(self) -> Lock:
if not hasattr(self.connection, 'lock'):
self.connection.lock = Lock()
return self.connection.lock
async def execute(self, query_string: str, args: Optional[Iterable[Any]] = None):
async with self.get_lock():
return await super().execute(query_string, args)
```
I recommend this feature to be standard on the base cursor, as it's often time impossible to avoid parallel queries happening at the same time.
### Describe alternatives you've considered
Another option would involve the connection holding an instance of `asyncio.Queue` to orchestrate any parallel queries going out, however I personally believe this is overkill and is not as simple to understand as a lock.
Another option I considered is subclassing each of the `Pool`, `Connection` and `Cursor` class to inject `LockedCursor` when calling `connection.cursor`, however that has proven to be very difficult and full of boilerplate and repetitive code to override the constructor and other methods simply to add a lock.
### Additional context
I am willing to help prepare a PR if this is a solution that the maintainers would approve of. I am also willing to discuss other potential solutions and approaches.
### Code of Conduct
- [X] I agree to follow the aio-libs Code of Conduct
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.