aio-libs / aio-libs/aiomysql

Ping should not ignore CancelledError

Open
#64 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
1.9k
Forks
272
PR merge metrics
No merged PRs in 30d

Description

This part:

``` Python
try:
yield from self._execute_command(COMMAND.COM_PING, "")
yield from self._read_ok_packet()
except Exception:
```

In ping function will result in strange behavior on cancelling coroutine. CancelledError should be propagated outside of this try/except without any reconnect.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.