aio-libs / aio-libs/aiokafka

Add support to disable hostname matching

Open
#855 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
1.4k
Forks
269
Avg merge
1d 1h
Merged PRs (30d)
6

Description

**Describe the solution you'd like**
The ability to set `ssl_check_hostname` in addition to the `ssl_context`.

**Additional context**
[kafka-python's KafkaConsumer](https://kafka-python.readthedocs.io/en/master/apidoc/KafkaConsumer.html#kafka.KafkaConsumer) supports this parameter to be able to disable whether the SSL/TLS handshake should verify that the certificate matches the broker's hostname.

Now, I know this opens up the possibility for man-in-the-middle attacks ([as mentioned even in the Python docs for loop.create_connection](https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.create_connection)), but would you consider adding the option to support this?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.