aio-libs / aio-libs/aiokafka

[QUESTION] on_partitions_assigned & getone/getmany

未關閉
#738 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
question
主要語言
Python
星號
1.4k
分支
269
平均合併
1 天 1 小時
30 天內合併 PR
6

描述

ConsumerRebalanceListener.on_partitions_assigned docstring says:

This method will be called *after* partition re-assignment completes
and *before* the consumer starts fetching data again.

I assume this follows original Java API description:

ConsumerRebalanceListener.onPartitionsAssigned

This method will be called after the partition re-assignment completes and before the consumer starts fetching data, and only as the result of a poll(long) call.

My interpretation of both doc is "the consumer will not consume from a newly assigned partition before the callback completes execution".

As I observe in my tests, this is not true at least for aiokafka.
Here is the line where fetcher is essentially unblocked from reading,
https://github.com/aio-libs/aiokafka/blob/fff2c021a57291a7484200a5f6b9e82611e59ed9/aiokafka/consumer/group_coordinator.py#L449
while listener is called 20 lines below.

Can anyone clarify, what is the desired behavior?

Thanks, Alexander

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。