aio-libs / aio-libs/aiohttp

Show where garbaged object was instantiated in warnings

Open
#11,235 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
16.5k
Forks
2.4k
Avg merge
17h 22m
Merged PRs (30d)
212

Description

### Is your feature request related to a problem?

We often get warnings of ClientSession and other objects that have not been closed properly, but it's often difficult to figure out which object is the problem and why it wasn't closed.

### Describe the solution you'd like

We can record the stack trace and include it in the warning, something along the lines of:
https://stackoverflow.com/a/22148022

This should be done under the `if DEBUG` flag to avoid performance impacts (although this may still be tricky to resolve flaky tests if we don't run them under debug mode by default).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.