aio-libs / aio-libs/aiohttp-security

Replace API functions

Aperta
#677 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
240
Fork
70
Merge medio
10m
PR unite (30g)
3

Descrizione

**Problem**

The API functions don't support static typing well. For example:

- If we want to allow other types for identity (e.g. #397), then we can't put types on these public API functions, as we wouldn't know what the correct type is.
- The `context` parameter must be typed as `Any` and default to `None` to be compatible with the API. However, some implementations may require a specific type for `context` and won't accept a default (e.g. aiohttp-admin). There's no way to validate this with a type checker.

**Solution**

I'm thinking the best approach will be to remove the API functions (everything in api.py), and then use the IdentityPolicy and AuthorizationPolicy classes directly.

A few tweaks will need to be made, but this should make it much easier to subclass and implement these with precise types.

Most of these functions are just calling the methods anyway, so there's not really any extra complexity to just call the methods directly.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.