aio-libs / aio-libs/aiohttp-cors
Missing type hints & readme updates
Offen
- Vorherrschende Sprache
- Python
- Sterne
- 220
- Forks
- 61
- Ø Merge
- 2 Min.
- Gemergte PRs (30 T.)
- 3
Beschreibung
As of v0.8.1, constructor of `ResourceOptions` does not have type hints, which causes an error, when type checking consumer code with MyPy in strict mode. A few functions & methods don't have the same issue, but could use type annotations, e.g.: `custom_cors` and `CorsConfig.add`.
There's also a couple of things that could be updated in the readme file:
1) `ResourceOptions` class is missing `s` at the end in one the examples;
2) `@asyncio.coroutine` could be replaced with `async` keyword.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.