aio-libs / aio-libs/aiodocker

Service update method does not match either docker-py nor docker Engine API spec

未关闭
#661 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
537
派生
118
PR 合并指标
30 天内没有已合并 PR

描述

## Long story short

We are trying to update a service using the library. However, the library does not offer the same functionality as the official specifications and it is just offering to perform a rollback.

In order to update the service, we are now deleting and creating it again which leaves us the service lacking the previous spec.

Docker official specs:
[docker-py](https://github.com/docker/docker-py/blob/master/docker/api/service.py#L363)
[docker engine API](https://docs.docker.com/engine/api/v1.41/#operation/ServiceUpdate)

* Expected behaviour: service update method match docker-py spec or docker Engine API spec
* Actual behaviour: missing update service features (only rollback is allowed)

## How to reproduce

1. We first register a service by calling `docker_client.services.create(data)` where data matches the required arguments from [aiodocker](https://github.com/aio-libs/aiodocker/blob/master/aiodocker/services.py#L39)
2. When trying to update the service registered in the 1st step, we are not able to pass the new spec as a method parameter and we are just able to send the [rollback](https://github.com/aio-libs/aiodocker/blob/master/aiodocker/services.py#L39)

## Your environment

1. Python 3.7.6
2. Docker version 20.10.11, build dea9396
3. aiodocker==0.19.1

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。