aiidalab / aiidalab/aiidalab-qe

Add a good test for QeAppWorkChain

Aberta
#645 0 comentários 0 reações 1 responsável Reivindicada por @superstar54 Ver no GitHub
enhancement
Linguagem predominante
Python
Estrelas
33
Forks
25
Merge médio
6h 7min
PRs com merge (30d)
8

Descrição

The old unit test uses a regression test on the final builder generated by the workchain. This is not a good design. Because the plugins depend on other packages, like aiida-quantumespresso, aiida-vibroscopy, and aiida-muon. Thus, the final builder also depends on those packages. In the latest work, we want to bump aside-quantum espresso to 4.5 and aside-core to 2.5, and the test failed because different aiida-quantumespresso produce different builder files.

In #644, I replaced the regression test using the ui_parameters generated by the app. This ui_parameter is the most important parameter. It contains all the information on the job, and one can use it to recreate the whole qeapp instance.

However, we still need a test on the QeAppWorkChain. The test should ideally only focus on the functionality of WorkChain itself.

For tests on the sub-WorkChains, which are related to the built-in plugins (bands, pdos, etc), one should add separate test files. In this way, the tests is clear and modularized.

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.