aiidalab / aiidalab/aiidalab-qe

Decouple UI state from workflow state

Abierto
#1,394 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
Python
Estrellas
33
Forks
25
Merge medio
6 h 7 min
PR fusionados (30 d)
8

Descripción

Currently, our models' `get/set_model_state` methods follow the format of aiida-quantumespresso, rather than that of the app. Best we update these to follow the UI format, converting to workflow format at submission.

For example, smearing choices in the UI aren't saved unless the user also selects a metallic state. Another is the shape of the eigenvalues in the Hubbard model (UI different from workflow inputs), for which we have to parse both ways. These sort of things should only happen at the workflow level.

Need to think carefully w.r.t backwards compatibility.

Pinging @superstar54

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.