aigc-apps / aigc-apps/VideoX-Fun

WanFunV2VSampler: pop from empty list

Open
#137 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.3k
Forks
188
Avg merge
2d 22h
Merged PRs (30d)
3

Description

Just running the standard workflow with no changes, and a LoRA added via the Load Fun Lora node, I got this:

ComfyUI Error Report

Error Details

  • Node ID: 91
  • Node Type: WanFunV2VSampler
  • Exception Type: IndexError
  • Exception Message: pop from empty list

Stack Trace

  File "/workspace/ComfyUI/execution.py", line 327, in execute
    output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)

  File "/workspace/ComfyUI/execution.py", line 202, in get_output_data
    return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)

  File "/workspace/ComfyUI/execution.py", line 174, in _map_node_over_list
    process_inputs(input_dict, i)

  File "/workspace/ComfyUI/execution.py", line 163, in process_inputs
    results.append(getattr(obj, func)(**inputs))

  File "/workspace/ComfyUI/custom_nodes/VideoX-Fun/comfyui/wan2_1_fun/nodes.py", line 736, in process
    pipeline = merge_lora(pipeline, _lora_path, _lora_weight, device="cuda", dtype=weight_dtype)

  File "/workspace/ComfyUI/custom_nodes/VideoX-Fun/videox_fun/utils/lora_utils.py", line 412, in merge_lora
    temp_name += "_" + layer_infos.pop(0)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with custom_nodes/VideoX-Fun/comfyui/wan2_1_fun/nodes.py at the WanFunV2VSampler process method, then inspect custom_nodes/VideoX-Fun/videox_fun/utils/lora_utils.py around merge_lora line 412. Reproduce the standard workflow with a LoRA loaded through Load Fun Lora and trace why layer_infos is empty. Done means the workflow no longer raises IndexError: pop from empty list.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.