aidotse / aidotse/LeakPro

ReportHandler.save() method config=None case only works for MIA

未關閉
#294 0 則留言 0 個 reaction 已指派 2 人 已被 @viktorvaladi 認領 在 GitHub 檢視
主要語言
Python
星號
23
分支
28
平均合併
4 天 12 小時
30 天內合併 PR
5

描述

# Issue
## Problem Description
In the save() method for report handler it tries to set a default config when "None" config is given.
This method is supported for MIAResult with
`AttackFactoryMIA.attack_classes[attack_name].get_default_attack_config()`

For other attacks, e.g. GIAResults where there is both InvertingConfig and HuangConfig, this is not currently supported

## Expected Behavior
ReportHandler.save() should either handle them based on resulttype (MIAResult, GIAResults, ... ) or better yet, have a more generic way of handling it.

## What Needs to be Done
Implement a default config method for GIAResults/AttackFactoryGIA

## How Can It Be Tested or Reproduced
Various attacks, including GIA should be saved preferebly with a type-specific default config implementation when config=None is given

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。