ahrefs / ahrefs/devkit

logstash flush should not die because of enospc

Open
#53 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
37
Forks
14
Avg merge
2d 21h
Merged PRs (30d)
3

Description

Uncaught exception:
  (Sys_error "No space left on device")

Raised by primitive operation at Devkit_core__Logstash.log.object#flush in file "logstash.ml", line 250, characters 44-54
Called from Devkit_core__Logstash.setup_error_log.(fun) in file "logstash.ml", line 263, characters 6-30
Called from Devkit_core__Log.State.Put.output in file "log.ml", line 100, characters 47-66

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in logstash.ml at line 250, where Devkit_core__Logstash.log.object#flush raises the Sys_error, then read the setup_error_log call around line 263 and the output path in log.ml around line 100. Determine how an ENOSPC error should be handled; done means flushing the error log no longer terminates with an uncaught exception when the device is full.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
observability
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.