ahmadfaizalbh / ahmadfaizalbh/django-oembed

Improvements suggestion

Ouverte
#20 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
auto-migrated Priority-Medium Type-Defect
Langage dominant
Python
Étoiles
0
Forks
0
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

```
Hi!

I'm using django-oembed in my project and I was really missing few things in it:
* I need not only to get widget's HTML, but also to get whole JSON (e.g. to
show video thumbnail)
* I can set only max_width/max_height now. But for example - Vimeo doesn't
scale video player up to max_width sometimes (if video quality is low). So I
need to pass extra parameter 'width' or 'height' to force scale Vimeo's player.
* And I have found few little bugs in code.

So I'm proposing my solution for all my requests - see the attached patch. It
contains:
* little bugfix
* new DB field: StoredOEmbed.oembed - TextField that stores whole JSON oEmbed
response
* Improved width/height: {% oembed !640x!480 %} and {{ video|oembed:"!400x100"
}} - !640 mean max_width = width = 640

Important! This patch is applicable for PyPI version 0.1.3 (not for the SVN
trunk here): http://pypi.python.org/pypi/django-oembed

Besides, I have a question: why django-oembed on PyPI is newer than trunk here?
Maybe django-oembed repository was moved to GitHub or BitBucket?
```

Original issue reported on code.google.com by `kottena...@gmail.com` on 22 Apr 2011 at 2:42

Attachments:
- [bigidea-video-width-fix.patch](https://storage.googleapis.com/google-code-attachments/django-oembed/issue-20/comment-0/bigidea-video-width-fix.patch)

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.