agronholm / agronholm/anyio

Restore signal handlers at the end of `open_signal_receiver`.

Aperta
#689 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
Python
Stelle
2.5k
Fork
260
Merge medio
1g 8h
PR unite (30g)
17

Descrizione

### Things to check first

- [X] I have searched the existing issues and didn't find my feature already requested there

### Feature description

Would it be possible to restore the original signal handlers at the end of `open_signal_receiver` instead of only removing them? I see that currently, we don't do that. Is there reason for this?

To restore signal handlers, they also have to be restored using ctypes after calling `remove_signal_handler`. See this code for an example on how to do that: https://github.com/prompt-toolkit/python-prompt-toolkit/blob/465ab02854763fafc0099a2e38a56328c1cb0625/src/prompt_toolkit/application/application.py#L1596

### Use case

(Use case is obvious I think. We have an application for which a main signal handler is installed at the beginning, however, during a portion of the code, we want to use `open_signal_receiver` to override the signal handler for that portion.)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.