agrc / agrc/supervisor

Do we really need to pass a logger to the exception handler?

Open
#14 1 comment 0 reactions 1 assignee View on GitHub

@jacobdadams is already working on this.

Since Oct 26, 2021.

enhancement
Dominant language
Python
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Generally, loggers should not be passed around (https://docs.python.org/3/howto/logging-cookbook.html#using-loggers-as-attributes-in-a-class-or-passing-them-as-parameters). I need to rethink how logging works in regards to supervisor (really, a proper understanding of logging may make supervisor superfluous...)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.