agrc / agrc/api-client

[Request]: Check rounding for 100% match rate

Open
#139 0 comments 0 reactions 2 assignees View on GitHub

@steveoh is already working on this.

Since Jul 18, 2022.

enhancement good first issue
Dominant language
TypeScript
Stars
5
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Is there an existing issue for this?
  • I have searched the existing issues
Is your feature request related to a problem? Please describe.

Sometimes the match rate seems to round up to 100% even if there's a failure or two
apiclientpercentage
.

Describe the solution you'd like

Maybe do a round to one decimal point, or a floor() call instead of rounding?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.