agrc / agrc/api-client

Do not log 404 requests

Open
#135 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
5
Forks
2
PR merge metrics
No merged PRs in 30d

Description

404's throw via got and are added to the client log when there is no problem and this is expected behavior. Filter out 404 requests from the logs.

https://github.com/agrc/api-client/blob/a306e8a0d1480536014e0e7bcf1a2eaf5ad75ae0/src/services/geocode.js#L174

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/services/geocode.js around line 174, where 404 responses from got enter the client log. Trace the existing logging path and confirm that expected 404 requests are the only entries to exclude. Done means 404 requests no longer appear in the client log while other relevant errors continue to be logged.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.