agiledigital / agiledigital/serverless-sns-sqs-lambda

Function names with dashes aren't supported

Open
#814 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
85
Forks
20
PR merge metrics
No merged PRs in 30d

Description

When using it on a function with dashes in its name, I'm getting a Cloudformation error on deploy:
```
Error:
The CloudFormation template is invalid: Template format error: Resource name Calculate-session-metricsEventSourceMappingSQSCalculateSessionMetricsQueue is non alphanumeric.
```

The function configuration is:
```
calculate-session-metrics:
timeout: 900
maximumEventAge: 1800
handler: ...
events:
- snsSqs:
name: CalculateSessionMetrics
topicArn: ${self:custom.eventsTopicArn}
omitPhysicalId: true
maxRetryCount: 3
deadLetterQueueEnabled: true
visibilityTimeout: 1800
filterPolicy:
name:
- ....
```

I think https://github.com/agiledigital/serverless-sns-sqs-lambda/pull/813 fixes it, but figured it's best to open an issue too

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.