ageron / ageron/handson-ml2

CHAPTER 08-PCA FROM SCRATCH

Open
#243 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
30k
Forks
13.1k
PR merge metrics
No merged PRs in 30d

Description

I have a question, why are you applying a SVD on a zero-mean (along the first axis) matrix? I'm not sure that's correct, I think you need to apply the SVD to the covariance matrix.
In fact, when checking the pca.explained_variance_ratio_, that corresponds only to component of the vector S returned by the SVD (normalized to the sum of elements in the vector) applied on a covariance matrix.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.