ageron / ageron/handson-ml

Chapter 6, exercise 8

Open
#406 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
25.6k
Forks
12.7k
PR merge metrics
No merged PRs in 30d

Description

Hi,
I am wondering in exercise 8 ln 24, should the tree classifier predict for `X_mini_test` which has 7900 elements instead of `X_test` as below?

```python
for tree, (X_mini_train, y_mini_train) in zip(forest, mini_sets):
tree.fit(X_mini_train,y_mini_train)
y_pred = tree.predict(X_mini_test)
accuracy_scores.append(accuracy_score(y_mini_test, y_pred))
```

If yes, then `mini_sets` for test elements should be also added in the for loop in ln 23 like

```python
for mini_train_index,mini_test_index in rs.split(X_train):
X_mini_train=X_train[mini_train_index]
y_mini_train=y_train[mini_train_index]
X_mini_test=X_train[mini_test_index]
y_mini_test=y_train[mini_test_index]
mini_sets.append((X_mini_train,y_mini_train))
mini_sets_test.append((X_mini_test,y_mini_test))
```

Otherwise, predicting X_test in ln 25 is redundant since y_pred was calculated before in ln 24.

Thanks,

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.