agent-substrate / agent-substrate/substrate

Deleting an actor leaks its in-progress snapshot when the template is gone

Open
#1,608 0 comments 0 reactions 1 assignee Claimed by @laoj2 View on GitHub
area/api-machinery area/storage kind/bug
Dominant language
Go
Stars
1.8k
Forks
316
Avg merge
2d 43m
Merged PRs (30d)
287

Description

ActorStatus.in_progress_snapshot_name holds only the snapshot's name, so
the delete workflow has to rebuild the storage prefix from the actor
template's snapshots_config.storage_location. If the template has been
deleted or renamed, the prefix cannot be derived: the workflow logs a
warning, skips the release, and the objects stay in the bucket forever.

Repro: suspend an actor, kill ateapi mid-checkpoint so the in-progress
name stays set, delete the template, then delete the actor. The actor
finalizes and the objects under its prefix remain.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.