agent-substrate / agent-substrate/substrate

ateapi needs better audit log

Aperta
#1,582 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
area/api-machinery area/observability area/security kind/feature
Lingua principale
Go
Stelle
1.8k
Fork
316
Merge medio
2g 43m
PR unite (30g)
287

Descrizione

Some gaps of the current ateapi audit logs:

1. Denied requests are never logged. The auth interceptor runs before the logging interceptor, so any request that fails auth just disappears. I sent calls with no token, a garbage token, and a Google ID token. All three got Unauthenticated back. Not a single line showed up in either api server pod, not even at debug level.

1. Stream RPCs are never logged. There is no logging interceptor on the stream chain. Reflection calls with a valid token leave no trace.

1. The principal is not the person. kubectl-ate mints a token for the shared ate-client service account, so every operator shows up as system:serviceaccount:ate-system:ate-client. The GKE audit log does not help either since TokenRequest is a data access event and is off by default.

1. No decision field, no resource field. We only have err. Which atespace or actor was touched is buried inside the serialized request and the shape is different for every RPC.

1. We log secrets. Redaction only clears fields named env. The response of MintJWT is a live actor bearer token and it is written to the log in full. Container command and args are logged too.

1. Too noisy to be an audit log. The router and egress health checks call ListActors every two seconds. That is about 7k log lines an hour on an idle cluster, each with the full response body.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.