aframevr / aframevr/aframe

Decreasing the Core code Size by making the mixin an entity instead of having its own element (discussion maybe needed)

Open
#5,764 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

I think we can make the overall code of A-Frame shorter, hence better for loading for first time, not sure if this can affect negatively, if we make the core code of an "" accepts pointing to (referencing) any other entity to be used as its mixin.

if the issues concerning are related to the nested mixins (an entity referencing another entity through "mixin" comp that by itself is also referencing to another entity), we can add a condition to check if the referenced mixin is already an entity that referencing another entity and warn the user (who use inspector/editor) and developers (who directly code)..!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing the core and mixin component, then examine how nested references would affect the inspector/editor. Done requires an agreed design plus validation that the change preserves behavior and reduces core code size.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.