oob-collider not setting el.object3D as default
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 17.6k
- Forks
- 4.4k
- PR merge metrics
- No merged PRs in 30d
Description
Description:
- A-Frame Version: 1.5.0
- Platform / Device: any
- Reproducible Code Snippet or URL:
By checking the obb-collider component I have two doubts:
-
Is there really a need of calling checkTrackedObject inside tick? As the trackedObject is changed via property update, it should be called inside update and not in every tick. I think it will work the same, but less work.
-
The oob-collider system emit the event to both collider entities and uses component.trackedObject3D. However inside the component this.trackedObject3D is never defined as default to this.el.object3D and the emit goes empty.
In some of the component methods we see || this.el.object3D, but never assign it to this.trackedObject3D
Regards,
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the obb-collider component and its system event path, focusing on checkTrackedObject, update, tick, and trackedObject3D. Verify whether the tracked object can default to this.el.object3D and whether the check can move from tick to update; done means both reported concerns are resolved without breaking collider event behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100