device-orientation-permission-ui dialog should emit rejected event when clicked denied on first dialog
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 17.6k
- Forks
- 4.4k
- PR merge metrics
- No merged PRs in 30d
Description
Description:
When the device-orientation-permission-ui dialog is prompted to user, it does not emit the event "deviceorientationpermissionrejected" when user clicks on deny in the first dialog. The event is emitted only when user denies the safari permission dialog. My suggestion is to emit the event "deviceorientationpermissionrejected" on the first deny (aframe custom dialog), or emit another custom event, because it's not possible to know if the user clicked on deny in the first dialog and consequently it's not possible to guide the user on how to allow the device orientation permission.
I can make a pull request adding the event to onDeviceMotionDialogDenyClicked if that's allowed.
- A-Frame Version: 1.0.4
- Platform / Device: Iphone XR
- Reproducible Code Snippet or URL:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating onDeviceMotionDialogDenyClicked and tracing the device-orientation-permission-ui flow for the first dialog and Safari permission dialog. Done means the first denial is observable through deviceorientationpermissionrejected or a clearly documented replacement event, without losing the existing Safari denial behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100