Consider checking `document.pointerLockElement` in `shouldCaptureKeyEvent`
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 17.6k
- Forks
- 4.4k
- PR merge metrics
- No merged PRs in 30d
Description
Context in https://github.com/donmccurdy/aframe-extras/pull/321, perhaps not automatically true if pointerlock is enabled, but may need to look for document.activeElement === document.pointerLockElement or similar.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked A-Frame source at src/utils/index.js#L246-L254 and inspect shouldCaptureKeyEvent in the context of the pointer-lock behavior described in PR 321. Determine whether document.pointerLockElement or the active-element relationship should affect capture, then verify the expected behavior with the relevant existing tests or a focused reproduction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100