aframevr / aframevr/aframe

v1.0.4 references external github dependencies which aren't pullable behind a firewall

Open
#4,564 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

Description:
External Github dependencies are difficult to cache with tools like https://github.com/verdaccio/verdaccio

The following deps have github references:

  • "document-register-element": "dmarcos/document-register-element#8ccc532b7f3744be954574caf3072a5fd260ca90",
  • "three-bmfont-text": "dmarcos/three-bmfont-text#1babdf8507c731a18f8af3b807292e2b9740955e",
  • "markserv": "github:sukima/markserv#feature/fix-broken-websoketio-link",
  • "too-wordy": "ngokevin/too-wordy",

We were evaluating a package that consumed this dependency, but when I was trying to pull from cache, I noticed this package tries to pull deps from github (which we're behind the firewall and clients aren't able to).

  • A-Frame Version: 1.0.4
  • Platform / Device: N/A
  • Reproducible Code Snippet or URL: N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dependency declarations used to publish A-Frame v1.0.4 and compare the four GitHub references listed in the issue with available package releases. The work is done when the published dependency metadata no longer requires direct GitHub access and installation can resolve the dependencies from a cache behind a firewall.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, javascript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.