aframevr / aframevr/aframe

make webgl2 optional to initialize webgl context

Open
#4,218 1 comment 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

Webgl2 shaders dont compile with the current context created by aframe. ThreeJs default context is weblg1, and doesnt allow to work with webgl2 reserved words.
I had to modify a-scene.js file to support my shaders using "sampler3D". Shouldnt be optional to be able to create a webgl2 context?

  • A-Frame Version:
  • Platform / Device:
  • Reproducible Code Snippet or URL:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in a-scene.js, where A-Frame creates the WebGL context, and inspect how the current Three.js context is initialized. Reproduce the shader failure involving the WebGL2 reserved word "sampler3D" and determine the expected optional WebGL2 initialization behavior; done means WebGL1 remains supported while WebGL2 shaders can initialize when requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, three.js
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.