aframevr / aframevr/aframe

Feature Request: Add `startEvents`, `pauseEvents` and `resumeEvents` to `sound` component

Open
#4,056 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

Description:

The animation component has properties for startEvents, pauseEvents and resumeEvents, each of which accept an array of events, which makes things pretty convenient when setting things up declaratively.

The sound component, on the other hand, only has the on property, which only accepts a single event. There's currently no way to easily turn off a loop declaratively in the same manner, for example.

Since animation and sound often go hand in hand, it would likely be beneficial if they followed the same paradigm.

If it makes sense, on could remain for backward compatibility and so there are no breaking changes.

Thanks for the consideration, and keep up the awesome work.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the animation component's startEvents, pauseEvents, and resumeEvents behavior with the sound component's existing on property. Trace how sound events are currently handled, then verify that declarative event arrays support starting, pausing, and resuming while preserving the existing on behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
audio-video-rtc
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.