aframevr / aframevr/aframe

Make Systems into Components internally.

Open
#4,010 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

Description:

Systems should be just components that are initialized first, and are registered with the alias registerSystem.

I'd also consider eliminating the this.system magic in favor of scene.systems['the-system-you-want-to-talk-to'] since we could often have multiple types of related components talking under one system, a 1-to-1 mapping doesn't make always sense.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by tracing how systems and components are registered and initialized, then identify every use of the system-to-component mapping and this.system magic. Done means systems behave as initially registered components and callers can address the intended system through scene.systems without breaking existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.