Add "request error" to materialtextureloaded, or error callback for texture loading
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 17.6k
- Forks
- 4.4k
- PR merge metrics
- No merged PRs in 30d
Description
Description:
Right now if texture was not loaded with, for example, 404, callback is still fired, and there is no way to determine if texture was loaded or not
here texture loading error is handled
https://github.com/aframevr/aframe/blob/4a44a804bbf7347e41fdc88daa6fa1d68756029d/src/systems/material.js#L312
and herematerialtextureloaded event is fired
https://github.com/aframevr/aframe/blob/4a44a804bbf7347e41fdc88daa6fa1d68756029d/src/utils/material.js#L119
- A-Frame Version: 0.8.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the texture error handling in src/systems/material.js around line 312 and the materialtextureloaded event in src/utils/material.js around line 119. Determine how the loading failure should be exposed through the event or callback, then verify that consumers can distinguish successful and failed texture loads.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100