aframevr / aframevr/aframe

Don't fire click event when mouse is dragged

Open
#3,493 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted (easy)
Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

As mentioned in #2625, the click event fires when the mouse is dragged, which is inconsistent with the way click events normally are fired in the browser.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the related discussion in issue #2625 and trace where A-Frame turns mouse input into its click event. Compare that behavior with normal browser click events during a drag. Done means a dragged mouse interaction no longer fires click, while an ordinary click still does.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.