setAttribute with clobber true, does not remove some material properties
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 17.6k
- Forks
- 4.4k
- PR merge metrics
- No merged PRs in 30d
Description
setAttribute with clobber set to true doesn't remove some material properties like normal maps, occlusion maps and displacement maps:
- 0.71
- Chrome / OSX High Sierra:
- https://jsfiddle.net/vcrnnkbg/3/
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the setAttribute behavior in the linked JSFiddle using A-Frame 0.7.1 on the reported environment, focusing on clobber=true with normal maps, occlusion maps, and displacement maps. Trace the material-property update path and verify that each listed property is removed when clobbering is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100