aframevr / aframevr/aframe

[stats] Faces limit seems low.

Open
#3,024 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

Someone pointed out in Slack that the default <a-sky/> element already exceeds the faces limit:

screen shot 2017-09-04 at 8 53 20 pm

Maybe the sphere resolution should be lowered, maybe not, but regardless I think the stats threshold seems too low. Seems like the limit should be at least maxVertices / 3?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the stats face-limit calculation and compare it with the default element and the proposed maxVertices / 3 threshold. Done means deciding whether the threshold or sphere resolution should change and verifying that the default element no longer exceeds the intended limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.