aframevr / aframevr/aframe

empty string value always becomes default schema value

Open
#2,623 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

... so there is no way to actually pass in empty string in distinguishable fashion (e.g. {type:'string', default:undefined} doesn't work since empty string BECOMES undefined)

codepen example http://codepen.io/machenmusik/pen/XRjYBO

note that it doesn't actually matter whether type is string or omitted entirely.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CodePen example and reproduce how an empty string is processed when a schema has a default value. Trace the schema value handling to determine where the empty string is converted, then verify that an explicitly supplied empty string remains distinguishable from an omitted value or the default.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.