shader lifecycle methods not consistent with component lifecycle methods
Open
Nobody has claimed this yet.
code quality
- Dominant language
- JavaScript
- Stars
- 17.6k
- Forks
- 4.4k
- PR merge metrics
- No merged PRs in 30d
Description
Description:
When components are initialized, they run init and then update right after.
Currently when shaders are initialized, they only run init. And update is only called on update.
This can cause code to be needed to be duplicated between shader init + update.
- A-Frame Version:
- Platform/Device:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by locating the shader lifecycle entry points and the corresponding component initialization methods. Compare when each lifecycle method runs, then verify that shader initialization has the same initial init-then-update behavior described for components.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100