aframevr / aframevr/aframe

Prioritize scene component initialization

Open
#1,209 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

code quality
Dominant language
JavaScript
Stars
17.6k
Forks
4.4k
PR merge metrics
No merged PRs in 30d

Description

Description: Currently, child entities initialize before parent entities. The scene is the most-parent/root "entity". Thus, all entities initialize before the scene. This means that scene components aren't initialized when entities are initialized. This might cause components having to register listeners to the scene to do things such as retrieve the canvas. We should initialize scene components first (for now, all of them, until we see a use case to not do so).

  • A-Frame Version: master
  • Platform/Device: all

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the scene and child-entity initialization path to identify where scene components are initialized relative to entities. Verify the ordering across the relevant initialization flow, then add or update coverage so scene components are initialized before entity components and run the existing test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.