aethant / aethant/merino

An in-range update of deep-equal is breaking the build 🚨

Offen
#460 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
greenkeeper
Vorherrschende Sprache
Keine Sprachdaten
Sterne
3
Forks
1
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

## The dependency [deep-equal](https://github.com/substack/node-deep-equal) was updated from `1.0.1` to `1.1.0`.

🚨 [View failing branch](https://github.com/aethant/merino/compare/master...aethant:greenkeeper%2Fdeep-equal-1.1.0).

This version is **covered** by your **current version range** and after updating it in your project **the build failed**.

deep-equal is a direct dependency of this project, and **it is very likely causing it to break**. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

- ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/aethant/merino/builds/577687277?utm_source=github_status&utm_medium=notification)).

---

Commits

The new version differs by 22 commits.



  • 6099799 v1.1.0

  • 0c25e94 [Tests] make a tape helper, to easily compare loose/strict, and (a,b)/(b,a) arg order

  • 3fffed9 [Tests] clean up/flesh out test cases

  • cbbef21 [Tests] clean up redundant test

  • 410e2d6 [Refactor] objEquiv: bail early if typeofs are different

  • 0c5b21a [Fix] use is-date-object to properly detect cross-realm Dates

  • de4e75c [Fix] ensure Buffer + non-Buffer comparison order does not matter

  • 5b3bf31 [Refactor] move Date and RegExp tests into objEquiv

  • 558eecf [Tests] add array/object tests

  • ed266e8 [Tests] add tests for Object.create(null)

  • b8c179c [Fix] properly compare RegExp objects

  • 6a5efc1 [Refactor] there is no need to do further compareation when two types are not equal

  • 28fde4a [Fix] use object-is to support NaN and -0 properly

  • 7000403 [meta] fix license text so GitHub can detect it

  • bc37498 test: Fails simple array tests on IE < 9 #10


There are 22 commits in total.


See the full diff

FAQ and help

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

---

Your [Greenkeeper](https://greenkeeper.io) Bot :palm_tree:

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.