aesmail / aesmail/kaffy

[BUG] embedded_schema @primary_key false not supported

Open
#190 1 comment 0 reactions 1 assignee Claimed by @aesmail View on GitHub
bug
Dominant language
Elixir
Stars
1.4k
Forks
171
PR merge metrics
No merged PRs in 30d

Description

**Versions Used**
Kaffy: 0.9.0
Phoenix: 1.5.7
Elixir: 1.11.2

**What's actually happening?**
Creating a new resource of a schema that contains an embedded_schema without an id will result in an error `key :id not found in ...` (see screenshot below).

**What should happen instead?**
The create/update should not expect a primary_key or id key to be set for the embedded_schema if it was defined it should not use one.

**Workaround**
Removing the `@primary_key false` makes everything work properly but an Id field will be added to the form which I don't need.

**Screenshots**

Screenshot 2020-12-29 at 15 06 14

Screenshot 2020-12-29 at 15 04 47

Happy to help @aesmail, let me know if this makes sense or I am doing something I shouldn't 💪

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.