aehrc / aehrc/pathling

Alternative approach for defining named UDFs.

Open
#869 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

refactoring
Dominant language
Java
Stars
134
Forks
24
Avg merge
1d 15h
Merged PRs (30d)
8

Description

See branch: spike/340
Package: au.csiro.pathling.sql.udfs;

This approach uses annotations rather then Spring beans and my be more appropriate if these the UDFS (such as datetime or quantity operations) needed to be exposed from python interface.

Also UDFs should be more focused on unit testing the UDF operations themselves rather that the FhirPaths that use them. Or at least it would be probably easier to write more through tests cases for the UDFs (regardless if they are beans or functions) than for FhirPaths. And also I assume that in the future we my want/need to expose these UDFs in the python API (so perhaps they should be tested independently from FhirPaths).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with branch spike/340 and package au.csiro.pathling.sql.udfs; compare annotation-based UDF definitions with the Spring-bean approach. Review how datetime and quantity operations are exposed and how their tests relate to FHIRPath tests. Done means a decided, independently tested UDF approach suitable for possible Python exposure.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, python, spring
Domain
api, backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.