aehrc / aehrc/pathling

Collections are not supported for custom encoders

Open
#375 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

new feature
Dominant language
Java
Stars
134
Forks
24
Avg merge
1d 15h
Merged PRs (30d)
8

Description

Currently custom encoded types (i.e. decimal and IdType) are not supported for fields with cardinality greater than one.
Attempts to encode/decode such type produce an exception "Collections are not supported for custom encoders".

Some of these include:

  "Parameters",
  // Collections are not supported for custom encoders for: condition-> RuntimeIdDatatypeDefinition[id, IdType]
  "Task",
  // Collections are not supported for custom encoders for: condition-> RuntimeIdDatatypeDefinition[id, IdType]
  "StructureDefinition",
  // Collections are not supported for custom encoders for: condition-> RuntimeIdDatatypeDefinition[id, IdType]
  "MolecularSequence",
  // Collections are not supported for custom encoders for: precision-> RuntimePrimitiveDatatypeDefinition[decimal, DecimalType]
  "StructureMap",
  // Collections are not supported for custom encoders for: condition-> RuntimeIdDatatypeDefinition[id, IdType]
  "PlanDefinition"
  // Collections are not supported for custom encoders for: goalId-> RuntimeIdDatatypeDefinition[id, IdType]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the encoding and decoding failures for collection-valued custom types listed in the issue, including IdType and DecimalType. Trace the custom encoder path to identify the source of the exception, then verify that the affected examples no longer fail for fields with cardinality greater than one.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spark
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.