Parameters annotated with @Nullable fail with null in Builders
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 134
- Forks
- 24
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 8
Description
Describe the bug
The builder methods in DataSinkBuilder and DataSourceBuilder have many methods annotated with @Nullable but they are checked to be non-null.
To Reproduce
new DataSourceBuilder(pathlingContext).parquet(null) // error, but annotated with nullable
Expected behavior
Many (if not all?) @Nullable annotations should be replaced with @Nonnull.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting DataSinkBuilder and DataSourceBuilder, focusing on methods annotated with @Nullable and their null checks. Reproduce the DataSourceBuilder(pathlingContext).parquet(null) behavior, then review the other builder methods for the same mismatch. Done means the annotations consistently describe whether null is accepted or rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100