Refactor operator resolution

Open

#2,453 opened on Jul 14, 2025 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 30/100

Issue type: Refactor
Clarity: Needs clarification
Activity status: Stale
Tech stack: java
Domain: compilers

Research direction

Start with the Visitor entry point and its visitBinaryOperator method, then compare the existing function-resolution path referenced by the issue. Determine where operator resolution should occur and how it should be encapsulated. Done means the operator lookup no longer lives directly in Visitor and the resolution timing decision is reflected consistently.

Written by the indexing model from the issue text.

Description

fhirpath refactoring

Encapsulate operator resolution in the manner similar to function resolution.
Decide when do perform the operator resolution (maybe should be at execution time same as for functions)
or maybe the functions should be resolved at parse time as well.

See: Visitor:

  // TODO: encapsulate in operator resolver
  // Decide when do perform the operator resolution (maybe should be at execution time same as for functions)
  // or maybe the functions should be resolved at parse time as well.
  private static final Map<String, BinaryOperator> BINARY_OPERATORS = MethodDefinedOperator.mapOf(
      CollectionOperations.class);

  @Nonnull
  private FhirPath visitBinaryOperator(
      @Nullable final ParseTree leftContext,
      @Nullable final ParseTree rightContext, @Nullable final String operatorName) {
    requireNonNull(operatorName);
    return new EvalOperator(new Visitor().visit(leftContext),
        new Visitor().visit(rightContext),
        Optional.ofNullable(BINARY_OPERATORS.get(operatorName))
            .orElseGet(() -> BinaryOperatorType.fromSymbol(operatorName).getInstance()));

Dominant language: Java
Stars: 134
Forks: 24
Avg merge: 1d 15h
Merged PRs (30d): 8

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug] [Connector-V2] [Http] A streaming Http source never completes a checkpoint: poll_interval_millis is waited out holding the checkpoint lock Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

apache/seatunnel#12411 · Opened Sep 20, 2026
wafv2: TagResource/UntagResource don't enforce the 50-tag limit or key/value length limits Open

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

floci-io/floci#4035 · Opened Sep 20, 2026
[Bug]: 26.3 Missing directional_particles in ConsumeEffect Open

bug needs triage

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

Minestom/Minestom#3375 · Opened Sep 20, 2026
The `grepIn` javadoc example never matches real XMIR, so a user who copies it silently gets no optimization Open

Difficulty 1/5 Under an hour Newbie friendliness 94/100

objectionary/hone-maven-plugin#1061 · Opened Sep 20, 2026
Store the original domain event in the Namastack outbox Open

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

spring-projects/spring-modulith#1895 · Opened Sep 20, 2026

More Java issues