adoptium / adoptium/installer

Clarify some of the field descriptions on the `create_installer_windows` job

Open
#522 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jinja
Stars
168
Forks
77
Avg merge
2d 14h
Merged PRs (30d)
12

Description

Clarify some of the field descriptions on the create_installer_windows (maybe others) jobs. It says JDK should be "openj9" or "hotspot" whereas the likely option now is "temurin". Also ensure that examples are provided in JDK8 and JDK11+ format. Ditto for sign_installer's "FULL_VERSION" parameter. Also [sign_installer](https://ci.adoptopenjdk.net/job/build-scripts/job/release/job/sign_installer/) cannot directly pick up from [create_installer_windows ](https://ci.adoptopenjdk.net/job/build-scripts/job/release/job/create_installer_windows) a it uses [a hard coded path](https://github.com/adoptium/installer/blob/c01d1ab0b977be55cb3fd9d70859ae0dc2d843f1/codesign/eclipse-codesign.sh#L26) which does not include `wix/ReleaseDir` which is what comes out of the installer job.

_Originally posted by @sxa in https://github.com/adoptium/adoptium/issues/155#issuecomment-1204956422_

Contributor guide

Open the contributing guide

Research direction

Review the create_installer_windows and sign_installer job descriptions, including the JDK and FULL_VERSION fields, and compare their examples for JDK8 and JDK11+. Then inspect eclipse-codesign.sh at line 26 against the create_installer_windows output path, including wix/ReleaseDir. Done means the descriptions are accurate and sign_installer can use the installer output path.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, ci-cd
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.