adoptium / adoptium/installer

Improve temurin special case is not handled on the caller side ?

Open
#441 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jinja
Stars
168
Forks
77
Avg merge
2d 14h
Merged PRs (30d)
12

Description

@sxa, @karianna Why this special case is not handled on the caller side ?
temurin is not a JVM so the JVM arg must not accept "temurin" and hide some other value behind ..

If you set upsteam a vendor name temurin , his place is in VENDOR_BRANDING from this script, not in JVM arg

I think in caller job you must do somthing like that:
if (VARIANT == "temurin" )
VENDOR_BRANDING"=Temurin"
JVM="hotspot" // default JVM for VARIANT "temurin"
call createInstallerJob
fi

_Originally posted by @douph1 in https://github.com/adoptium/installer/pull/438#discussion_r810872958_

Contributor guide

Open the contributing guide

Research direction

Start by locating the caller job that invokes createInstallerJob and inspect how VARIANT, JVM, and VENDOR_BRANDING are passed. Confirm how the temurin variant is represented, then verify that its vendor branding and default JVM value are handled before the installer job is created.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.