adoptium / adoptium/installer

Common Installer gotcha's (that maybe we can catch)

Open
#353 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jinja
Stars
168
Forks
77
Avg merge
2d 14h
Merged PRs (30d)
12

Description

I've assembled a list of common installer gotchas that have forced us to re-release in the past.

- Eclipse Codesigning service failed to handle MSI's and returned a text file. - Fixed via https://github.com/adoptium/installer/pull/324
- Incorrect vendor name in MSI's. - We had to change the name to Eclipse Foundation and rebuild all MSI's.
- macOS binary wasn't deep signed properly - Fixed via https://github.com/adoptium/temurin-build/pull/2712
- `jpackageapplauncher` wasn't codesigned on JDK16+ - Fixed via https://github.com/adoptium/ci-jenkins-pipelines/pull/158
- macOS binaries had incorrectly signed jmods. This was fixed by moving the sign job to before the tests.
- macOS M1 installers required rosetta. This was fixed by https://github.com/adoptium/installer/pull/354

Contributor guide

Open the contributing guide

Research direction

No implementation file or test is named. Start by reviewing the installer repository and the linked historical fixes for the MSI, macOS signing, and Rosetta cases; done would require a concrete, agreed set of checks for the listed installer gotchas.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, macos
Domain
build-system, release, testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.