adoptium / adoptium/installer

Create a smoke test to check that correct tools are inside Linux installer packages

Open
#335 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jinja
Stars
168
Forks
77
Avg merge
2d 14h
Merged PRs (30d)
12

Description

I don't see `pack200` in here. Others might be missing, too. Others like `jlink` aren't in 8.

It's important to get this list right. Otherwise the packages spew tons of errors and make them unpleasant to use.

https://github.com/adoptium/installer/blob/master/linux/find_tools.sh makes it "easier" to list the binaries in a JDK. You still have to go through it with a fine comb. The old list from AdoptOpenJDK might be helpful, too: https://github.com/adoptium/installer/blob/master/linux/deb/config/jdk-8-hotspot/tools.txt.

Ideally, someone writes a test in the future that checks that all binaries are in the installed jinfo file and there aren't any tools in it that aren't in the JDK.

_Originally posted by @aahlenst in https://github.com/adoptium/installer/pull/332#discussion_r684624149_

Contributor guide

Open the contributing guide

Research direction

Start with linux/find_tools.sh and compare it with linux/deb/config/jdk-8-hotspot/tools.txt and the installed jinfo file. Define the expected tool list for the relevant JDK packages, then add a smoke test that detects missing binaries and entries for tools absent from the JDK.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, linux
Domain
build-system, release, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.